-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global tech preview indicator for service catalog #1712
Conversation
Seems fine to me. I could see someone getting annoyed with it and perhaps wanting to dismiss it. As far as the wording, I think the wording is fine if the text linked out to somewhere that described what was tech preview. Though I could see 2 different things being tech preview: 1. the UI/UX and 2. the underlying service catalog (and brokers). It might be handy to know when it is one or both. |
Per @jwforres, we sort of want it to be annoying as we will not be supporting service catalog in tech preview and do not want it to be overlooked.
Adding a link is easy. What it links to is the hard part. Who is to create the documentation and where does it live? |
Gonna go ahead and request review and merge on this with the understanding we'll possibly add a follow on to add a link. |
LGTM but don't think this qualifies for a blocker, would rather hold it till monday |
[merge] |
1 similar comment
[merge] |
Evaluated for origin web console merge up to 1c80c6b |
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1584/) (Base Commit: 066938a) (PR Branch Commit: 1c80c6b) |
Fixes #1699
Following the design direction set by the page-level "Technology Preview" badge, how about an orange bar above the navbar? Exact message wording to be determined.